# Staggered adoption and two-way fixed effects
# https://tidyecology.com/posts/staggered-adoption-twfe-bias/
#
# The R code of this Tidy Ecology tutorial, chunk by chunk, in the order of the post.
# Run it top to bottom in a fresh R session. Code the post shows but does not run
# is commented out. The prose, and the numbers it quotes, are in the post itself.
# Post last modified: 2026-10-15

## ---- setup ----
library(ggplot2); library(dplyr); library(tidyr)
set.seed(88)
Tn <- 12; npg <- 20; tg <- c(4, 7, 10); N <- 4 * npg
idL <- list(); for (i in seq_along(tg)) idL[[i]] <- ((i - 1) * npg + 1):(i * npg)
gvec <- rep(NA_integer_, N); for (i in seq_along(tg)) gvec[idL[[i]]] <- tg[i]   # NA = never-treated
att_dyn <- function(e) ifelse(e < 0, 0, 0.25 * (e + 1))                          # true dynamic effect
alph <- rnorm(N, 0, 0.7); lam <- cumsum(c(0, rnorm(Tn - 1, 0.03, 0.10))); sig <- 0.30
d <- expand.grid(id = 1:N, year = 1:Tn)
d$g <- gvec[d$id]; d$e <- ifelse(is.finite(d$g), d$year - d$g, NA_integer_)
d$D <- as.integer(is.finite(d$g) & d$year >= d$g)                                # treated-now
d$eff <- ifelse(d$D == 1, att_dyn(d$e), 0)
d$y <- alph[d$id] + lam[d$year] + d$eff + rnorm(nrow(d), 0, sig)
true_att <- mean(d$eff[d$D == 1])                                                # true overall ATT

## ---- twfe ----
m_twfe <- lm(y ~ factor(id) + factor(year) + D, d)
b_twfe <- coef(m_twfe)["D"]; se_twfe <- summary(m_twfe)$coefficients["D", "Std. Error"]

## ---- bacon ----
gm <- function(I, Y) mean(d$y[d$id %in% I & d$year %in% Y])
io <- function(g) which(gvec == g); inev <- which(!is.finite(gvec))
bacon <- list()
for (g in tg) {                                     # treated vs never (clean)
  post <- g:Tn; pre <- 1:(g - 1)
  did <- (gm(io(g), post) - gm(io(g), pre)) - (gm(inev, post) - gm(inev, pre))
  nk <- length(io(g)); nu <- length(inev); ntot <- nk + nu; sk <- nk / ntot
  w <- (sk * (1 - sk)) * (length(post) / Tn) * (length(pre) / Tn) * ntot^2
  bacon[[length(bacon) + 1]] <- data.frame(type = "treated vs never", pair = sprintf("%d", g), did = did, w = w, forbidden = FALSE, ebar = mean(post - g))
}
for (a in 1:(length(tg) - 1)) for (b in (a + 1):length(tg)) {
  k <- tg[a]; l <- tg[b]
  win <- k:(l - 1); pre <- 1:(k - 1)                # early treated vs later not-yet (clean)
  did1 <- (gm(io(k), win) - gm(io(k), pre)) - (gm(io(l), win) - gm(io(l), pre))
  nk <- length(io(k)); nl <- length(io(l)); ntot <- nk + nl; sk <- nk / ntot
  w1 <- (sk * (1 - sk)) * (length(win) / Tn) * (length(pre) / Tn) * ntot^2
  bacon[[length(bacon) + 1]] <- data.frame(type = "early vs later-control", pair = sprintf("%d|%d", k, l), did = did1, w = w1, forbidden = FALSE, ebar = mean(win - k))
  win2 <- l:Tn; pre2 <- k:(l - 1)                   # late treated vs already-treated early (forbidden)
  did2 <- (gm(io(l), win2) - gm(io(l), pre2)) - (gm(io(k), win2) - gm(io(k), pre2))
  w2 <- (sk * (1 - sk)) * (length(win2) / Tn) * (length(pre2) / Tn) * ntot^2
  bacon[[length(bacon) + 1]] <- data.frame(type = "late vs already-treated", pair = sprintf("%d|%d", l, k), did = did2, w = w2, forbidden = TRUE, ebar = mean(win2 - l))
}
B <- do.call(rbind, bacon); B$w <- B$w / sum(B$w)
twfe_recon <- sum(B$w * B$did)
wforb <- sum(B$w[B$forbidden]); maxforb <- max(B$did[B$forbidden]); minforb <- min(B$did[B$forbidden])
clean_avg <- sum(B$w[!B$forbidden] * B$did[!B$forbidden]) / sum(B$w[!B$forbidden])     # clean comparisons alone
ebar_clean <- sum(B$w[!B$forbidden] * B$ebar[!B$forbidden]) / sum(B$w[!B$forbidden])   # their mean years since adoption
ebar_all <- mean(d$e[d$D == 1])                                                        # same over all treated site-years

## ---- fig-bacon ----
te <- list(ink="#16241d",body="#2c3a31",forest="#275139",label="#46604a",sage="#93a87f",paper="#f5f4ee",
           line="#dad9ca",faint="#5d6b61",grazed="#cda23f",mown="#2f8f63",aband="#b5534e")
th <- theme_minimal(base_size = 12) + theme(text = element_text(colour = te$body),
  plot.title = element_text(colour = te$ink, face = "bold"), plot.subtitle = element_text(colour = te$faint, size = rel(0.9)),
  axis.title = element_text(colour = te$label), axis.text = element_text(colour = te$faint), panel.grid.minor = element_blank(),
  panel.grid.major = element_line(colour = te$line, linewidth = 0.3), legend.position = "bottom",
  legend.text = element_text(colour = te$faint, size = rel(0.8)),
  plot.background = element_rect(fill = te$paper, colour = NA), panel.background = element_rect(fill = te$paper, colour = NA))
ggplot(B, aes(w, did, colour = type, size = w)) +
  geom_hline(yintercept = 0, colour = te$faint, linewidth = 0.4) +
  geom_hline(aes(yintercept = b_twfe, linetype = "TWFE weighted average"), colour = te$grazed, linewidth = 0.8) +
  geom_hline(aes(yintercept = true_att, linetype = "True overall ATT"), colour = te$forest, linewidth = 0.8) +
  geom_point(alpha = 0.9) + geom_text(aes(label = pair), size = 2.7, vjust = -1.1, show.legend = FALSE) +
  scale_colour_manual(values = c("treated vs never" = te$mown, "early vs later-control" = te$sage, "late vs already-treated" = te$aband), name = NULL) +
  scale_linetype_manual(values = c("TWFE weighted average" = "solid", "True overall ATT" = "31"),
                        breaks = c("TWFE weighted average", "True overall ATT"), name = NULL) +
  scale_size(range = c(2.5, 6), guide = "none") + guides(colour = guide_legend(nrow = 2, override.aes = list(size = 3)),
    linetype = guide_legend(override.aes = list(colour = c(te$grazed, te$forest)))) +
  labs(x = "Goodman-Bacon weight", y = "2x2 difference-in-differences estimate",
       title = "TWFE is a weighted average of 2x2 comparisons",
       subtitle = "The red 'late vs already-treated' comparisons turn negative under a growing effect\nand drag TWFE further below the truth.") + th

## ---- grouptime ----
cs <- list()
for (g in tg) {
  base <- g - 1
  for (t in g:Tn) {
    ctrl <- setdiff(which(!is.finite(gvec) | gvec > t), io(g))    # not-yet-treated (incl never)
    cs[[length(cs) + 1]] <- data.frame(g = g, t = t, e = t - g,
      att = (gm(io(g), t) - gm(io(g), base)) - (gm(ctrl, t) - gm(ctrl, base)))
  }
}
CS <- do.call(rbind, cs)
ag <- CS %>% group_by(e) %>% summarise(att = mean(att), .groups = "drop"); ag$true <- att_dyn(ag$e)
cs_overall <- mean(CS$att); maxdev <- max(abs(ag$att - ag$true))

## ---- fig-grouptime ----
ggplot(ag, aes(e, att)) +
  geom_hline(yintercept = 0, colour = te$faint, linewidth = 0.4) +
  geom_hline(aes(yintercept = b_twfe, linetype = "naive TWFE"), colour = te$grazed, linewidth = 0.8) +
  geom_line(aes(y = true, colour = "true ATT(e)"), linewidth = 0.7, linetype = "31") +
  geom_point(aes(y = true, colour = "true ATT(e)"), size = 1.4) +
  geom_line(aes(colour = "Callaway-Sant'Anna"), linewidth = 0.7) +
  geom_point(aes(colour = "Callaway-Sant'Anna"), size = 2.4) +
  annotate("text", x = 6.2, y = b_twfe - 0.14, label = sprintf("naive TWFE = %.2f", b_twfe), colour = te$grazed, size = 3.1) +
  scale_colour_manual(values = c("Callaway-Sant'Anna" = te$mown, "true ATT(e)" = te$forest), name = NULL) +
  scale_linetype_manual(values = c("naive TWFE" = "solid"), name = NULL) + scale_x_continuous(breaks = 0:8) +
  labs(x = "Event time (years since adoption)", y = "Average treatment effect on the treated",
       title = "A heterogeneity-consistent estimator recovers the dynamic effect",
       subtitle = "Group-time ATT with not-yet-treated controls tracks the true path; the single TWFE number does not.") + th
